Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix permission requirements for Deno.rename() and Deno.link() #2737

Merged
merged 1 commit into from
Aug 13, 2019
Merged

Fix permission requirements for Deno.rename() and Deno.link() #2737

merged 1 commit into from
Aug 13, 2019

Conversation

nayeemrmn
Copy link
Collaborator

@nayeemrmn nayeemrmn commented Aug 6, 2019 •
edited

Fixes #2736

@nayeemrmn nayeemrmn force-pushed the permission-patch branch 11 times, most recently from c5e0547 to ac130f4 Compare August 9, 2019 02:15
ry
ry approved these changes Aug 13, 2019
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry ry merged commit 1947f57 into denoland:master Aug 13, 2019
@nayeemrmn nayeemrmn deleted the permission-patch branch August 13, 2019 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju left review comments

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Insufficient permission requirements for Deno.rename() and Deno.link()
3 participants
@nayeemrmn @ry @bartlomieju